cpoerschke commented on code in PR #931:
URL: https://github.com/apache/solr/pull/931#discussion_r940475211
##########
solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java:
##########
@@ -190,7 +215,12 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
// Pick the action
final String action = req.getParams().get(ACTION,
STATUS.toString()).toLowerCase(Locale.ROOT);
- CoreAdminOperation op = opMap.get(action);
+ CoreAdminOp op = opMap.get(action);
+ log.warn(
+ "action '{}' not found, calling custom action handler. "
+ + "If original intention was to target some custom behaviour "
+ + "use custom actions defined in 'solr.xml' instead",
+ action);
if (op == null) {
Review Comment:
oops, i could/should have spotted this earlier, sorry. logging needs to be
within the `if` block.
```suggestion
if (op == null) {
log.warn(
"action '{}' not found, calling custom action handler. "
+ "If original intention was to target some custom behaviour "
+ "use custom actions defined in 'solr.xml' instead",
action);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
