HoustonPutman commented on code in PR #943:
URL: https://github.com/apache/solr/pull/943#discussion_r952899077
##########
solr/core/src/test/org/apache/solr/cloud/ReplaceNodeTest.java:
##########
@@ -115,9 +115,9 @@ public void test() throws Exception {
log.info("excluded_node : {} ", emptyNode);
createReplaceNodeRequest(nodeToBeDecommissioned, emptyNode, null)
.processAndWait("000", cloudClient, 15);
+ ZkStateReader zkStateReader = ZkStateReader.from(cloudClient);
Review Comment:
The method name does make it sound like it's possibly creating a new
instance. Maybe renaming the method to `extractFrom` could be helpful? Not a
deal breaker, just could be a bit easier to understand.
To be clear, this is out of scope for this ticket, was just thinking "out
loud".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
