dsmiley commented on code in PR #943:
URL: https://github.com/apache/solr/pull/943#discussion_r954045568
##########
solr/core/src/test/org/apache/solr/cloud/ReplaceNodeTest.java:
##########
@@ -115,9 +115,9 @@ public void test() throws Exception {
log.info("excluded_node : {} ", emptyNode);
createReplaceNodeRequest(nodeToBeDecommissioned, emptyNode, null)
.processAndWait("000", cloudClient, 15);
+ ZkStateReader zkStateReader = ZkStateReader.from(cloudClient);
Review Comment:
Not that SolrClient is already Closable and we should already be taking care
to manage their lifecycle. A CloudSolrClient that uses a ZK state provider
will close it.
##########
solr/core/src/test/org/apache/solr/cloud/ReplaceNodeTest.java:
##########
@@ -115,9 +115,9 @@ public void test() throws Exception {
log.info("excluded_node : {} ", emptyNode);
createReplaceNodeRequest(nodeToBeDecommissioned, emptyNode, null)
.processAndWait("000", cloudClient, 15);
+ ZkStateReader zkStateReader = ZkStateReader.from(cloudClient);
Review Comment:
Note that SolrClient is already Closable and we should already be taking
care to manage their lifecycle. A CloudSolrClient that uses a ZK state
provider will close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
