dsmiley commented on code in PR #962:
URL: https://github.com/apache/solr/pull/962#discussion_r957272587
##########
solr/core/src/java/org/apache/solr/core/XmlConfigFile.java:
##########
@@ -165,7 +152,6 @@ public XmlConfigFile(
db.setErrorHandler(xmllog);
try {
doc = db.parse(is);
Review Comment:
In this file, I suggested you could tweak it to use SafeXMLParsing to both
reduce code but moreover to make the "Safe"-ness more obvious. Did that turn
out to be hard or just don't want to bother? (either is fine)
##########
solr/CHANGES.txt:
##########
@@ -80,6 +80,8 @@ Optimizations
* SOLR-9359: Enable warming queries to be managed using Config API (Andy Webb,
Eric Pugh)
+* SOLR-16296: Remove the use of XmlConfigFile by QueryElevationComponent.
(Haythem Khiri)
Review Comment:
Can you move this out of the "Optimizations" section and into "Other"? In
the end this is some misc. refactoring that improves the code but is completely
invisible to users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
