heythm commented on code in PR #962:
URL: https://github.com/apache/solr/pull/962#discussion_r957744596
##########
solr/core/src/test/org/apache/solr/core/TestConfigSets.java:
##########
@@ -56,16 +56,12 @@ public CoreContainer setupContainer(String
configSetsBaseDir) {
public void testDefaultConfigSetBasePathResolution() {
Path solrHome = Paths.get("/path/to/solr/home");
- NodeConfig config =
- SolrXmlConfig.fromString(
- solrHome, "<solr><str
name=\"configSetBaseDir\">configsets</str></solr>");
+ NodeConfig config = SolrXmlConfig.fromString(solrHome);
assertThat(
config.getConfigSetBaseDirectory().toAbsolutePath(),
is(Paths.get("/path/to/solr/home/configsets").toAbsolutePath()));
- NodeConfig absConfig =
- SolrXmlConfig.fromString(
Review Comment:
I think we still need an XmlConfigFile constructor taking as input an
InputStream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
