noblepaul commented on PR #994: URL: https://github.com/apache/solr/pull/994#issuecomment-1237531682
>The main idea behind the other work is to update the parsing of elevate.xml. This induced cleaning up some things: removing XmlConfigFile and XPath from QEC. >Maybe https://github.com/apache/solr/pull/962 can be reduced in scope to only XmlConfigFile changes, I like the fact that #962 gets rid of `XmlConfigFile` . It should not be limited to just `elevate.xml` , we need to expand its scope to `solr.xml`, `schema.xml` & `solrconfig.xml`. `elevate.xml` is a very simple XML file and it doesn't really matter how we actually parse it. I just wanted all configuration XMLs to use the standard pattern. > We can merge the other PR where we can consider that the xpath work done there is a prework to this one. We can do in any order. It's OK. BTW can you please take a look at how the work done in #962 can be applied to the other XML files as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
