patsonluk opened a new pull request, #1032: URL: https://github.com/apache/solr/pull/1032
https://issues.apache.org/jira/browse/SOLR-16412 # Description Details of the issue is described in the JIRA issue linked above. Although we could enforce synchronization to prevent threads from purging the same set of child nodes, it might not be desirable to add extra blocking. Instead, we should be more forgiving `SizeLimitedDistributedMap#shrinkIfNeeded` if any items/nodes in the map no longer exist. # Solution Catch `KeeperEx1ception.NoNodeException` in `SizeLimitedDistributedMap#shrinkIfNeeded` if such node is already deleted, which is likely triggered by concurrent `shrinkIfNeeded` call. # Tests Added unit test case `TestSizeLimitedDistributedMap#testConcurrentCleanup`, it's shown that without the current fix, the exception will be thrown # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [x] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
