risdenk commented on code in PR #1032:
URL: https://github.com/apache/solr/pull/1032#discussion_r1003701865
##########
solr/core/src/java/org/apache/solr/cloud/SizeLimitedDistributedMap.java:
##########
@@ -91,9 +91,13 @@ protected boolean lessThan(Long a, Long b) {
for (String child : children) {
Long id = childToModificationZxid.get(child);
if (id != null && id <= topElementMzxId) {
- zookeeper.delete(dir + "/" + child, -1, true);
- if (onOverflowObserver != null)
- onOverflowObserver.onChildDelete(child.substring(PREFIX.length()));
+ try {
+ zookeeper.delete(dir + "/" + child, -1, true);
+ if (onOverflowObserver != null)
+
onOverflowObserver.onChildDelete(child.substring(PREFIX.length()));
+ } catch (KeeperException.NoNodeException e) {
Review Comment:
nit: naming the exception `ignore` or `ignored` I think makes IDEs not care
that the exception isn't used. It doesn't change the behavior at all just clear
we meant to ignore the exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
