risdenk commented on code in PR #1039:
URL: https://github.com/apache/solr/pull/1039#discussion_r978615551
##########
solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/InnerJoinStream.java:
##########
@@ -32,10 +32,14 @@
* @since 6.0.0
*/
public class InnerJoinStream extends BiJoinStream implements Expressible {
+ @SuppressWarnings("JdkObsolete")
+ private final LinkedList<Tuple> joinedTuples = new LinkedList<>();
- private LinkedList<Tuple> joinedTuples = new LinkedList<>();
- private LinkedList<Tuple> leftTupleGroup = new LinkedList<>();
- private LinkedList<Tuple> rightTupleGroup = new LinkedList<>();
+ @SuppressWarnings("JdkObsolete")
+ private final LinkedList<Tuple> leftTupleGroup = new LinkedList<>();
+
+ @SuppressWarnings("JdkObsolete")
Review Comment:
Note to self @risdenk: Create follow up jira to try to remove these.
##########
solr/core/src/java/org/apache/solr/packagemanager/RepositoryManager.java:
##########
@@ -71,15 +71,16 @@ public RepositoryManager(HttpSolrClient solrClient,
PackageManager packageManage
this.solrClient = solrClient;
}
- public List<SolrPackage> getPackages() {
- List<SolrPackage> list = new ArrayList<>(getPackagesMap().values());
+ public List<org.apache.solr.packagemanager.SolrPackage> getPackages() {
Review Comment:
Actually looks like the pattern is `...beans.*Payload` so going to change
the `SolrPackage` -> `PackagePayload`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
