risdenk commented on code in PR #1039:
URL: https://github.com/apache/solr/pull/1039#discussion_r978661778


##########
solr/benchmark/src/java/org/apache/solr/bench/generators/Lists.java:
##########
@@ -32,17 +31,13 @@ public final class Lists {
   private Lists() {}
 
   static <T> Gen<List<T>> listsOf(Gen<T> generator, Gen<Integer> sizes) {
-    return listsOf(generator, arrayList(), sizes).mix(listsOf(generator, 
linkedList(), sizes));

Review Comment:
   I'm going to revert these benchmark changes since doesn't seem to be 
necessary. 
https://github.com/quicktheories/QuickTheories/blob/master/core/src/main/java/org/quicktheories/core/Gen.java#L168
 btw says mix is just combining the links.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to