risdenk commented on code in PR #953:
URL: https://github.com/apache/solr/pull/953#discussion_r998771803
##########
solr/core/src/test/org/apache/solr/handler/TestSampleDocumentsLoader.java:
##########
@@ -63,7 +58,7 @@ public void testJson() throws Exception {
@Test
public void testCsv() throws Exception {
ModifiableSolrParams params = new ModifiableSolrParams();
- params.set(CSV_MULTI_VALUE_DELIM_PARAM, "\\|");
+ params.set(DefaultSampleDocumentsLoader.CSV_MULTI_VALUE_DELIM_PARAM,
"\\|");
Review Comment:
yea this was me just removing the static imports. It makes it clear that
this isn't a constant in the `TestSampleDocumentsLoader` class to me. Otherwise
it looks like a field in the class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
