risdenk commented on code in PR #953:
URL: https://github.com/apache/solr/pull/953#discussion_r998703160
##########
solr/solrj/src/test/org/apache/solr/client/solrj/io/stream/expr/InjectionDefenseTest.java:
##########
@@ -17,12 +17,10 @@
package org.apache.solr.client.solrj.io.stream.expr;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
-
+import org.apache.solr.SolrTestCase;
import org.junit.Test;
-public class InjectionDefenseTest {
+public class InjectionDefenseTest extends SolrTestCase {
Review Comment:
Get all the benefits of the underlying randomization and thread leak checks
from Lucene. This ensures that all these tests have a common base. There are no
real downsides to doing this either.
##########
solr/solrj/src/test/org/apache/solr/client/solrj/io/stream/eval/TemporalEvaluatorsTest.java:
##########
@@ -54,7 +52,7 @@
import org.junit.Test;
/** Tests numeric Date/Time stream evaluators */
-public class TemporalEvaluatorsTest {
+public class TemporalEvaluatorsTest extends SolrTestCase {
Review Comment:
Get all the benefits of the underlying randomization and thread leak checks
from Lucene. This ensures that all these tests have a common base. There are no
real downsides to doing this either.
##########
solr/solrj/src/test/org/apache/solr/client/solrj/io/stream/eval/ConversionEvaluatorsTest.java:
##########
@@ -32,7 +30,7 @@
import org.junit.Test;
/** Test ConversionEvaluators */
-public class ConversionEvaluatorsTest {
+public class ConversionEvaluatorsTest extends SolrTestCase {
Review Comment:
Get all the benefits of the underlying randomization and thread leak checks
from Lucene. This ensures that all these tests have a common base. There are no
real downsides to doing this either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
