risdenk commented on code in PR #953:
URL: https://github.com/apache/solr/pull/953#discussion_r999897558
##########
solr/modules/sql/src/test/org/apache/solr/handler/sql/TestSQLHandler.java:
##########
@@ -425,22 +424,22 @@ public void testBasicSelect() throws Exception {
tuples = getTuples(sParams, baseUrl);
- assert (tuples.size() == 3);
+ assertEquals(3, tuples.size());
tuple = tuples.get(0);
- assert (tuple.getLong("myId") == 3);
- assert (tuple.getLong("myInt") == 20);
- assert (tuple.get("myString").equals("a"));
+ assertEquals(3, (long) tuple.getLong("myId"));
Review Comment:
addressed in 6492b9a68252f92db11fbee074acbbbf05680a51 for all the `getLong`
and some other redundant casts I found along the way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
