risdenk commented on code in PR #953:
URL: https://github.com/apache/solr/pull/953#discussion_r999941029
##########
solr/core/src/test/org/apache/solr/core/QueryResultKeyTest.java:
##########
@@ -134,7 +134,6 @@ public void testRandomQueryKeyEquality() {
assertKeyNotEquals(aa, bb);
}
}
- assert minIters <= iter;
Review Comment:
This is always true.
##########
solr/core/src/test/org/apache/solr/search/join/BJQParserTest.java:
##########
@@ -178,7 +179,6 @@ public void testJustParentsFilterInChild() {
"//doc/arr[@name='child_s']/str='" + klm[0] + "'",
"//doc/arr[@name='child_s']/str='" + klm[1] + "'",
"//doc/arr[@name='child_s']/str='" + klm[2] + "'");
- assert klm.length == 3 : "change asserts pls " + Arrays.toString(klm);
Review Comment:
This is always true
##########
solr/core/src/test/org/apache/solr/legacy/TestLegacyFieldReuse.java:
##########
@@ -53,7 +53,6 @@ public void testNumericReuse() throws IOException {
// pass another bogus stream (numeric, but different precision step!)
legacyIntField = new LegacyIntField("foo", 42, Field.Store.NO);
- assert 3 != LegacyNumericUtils.PRECISION_STEP_DEFAULT;
Review Comment:
this is always true
##########
solr/core/src/test/org/apache/solr/handler/TestStressThreadBackup.java:
##########
@@ -243,8 +243,6 @@ public void run() {
// and how few iterations we have left
if (3 < namedSnapshots.size()
&& random().nextInt(3 + numBackupIters - i) <
random().nextInt(namedSnapshots.size())) {
-
- assert 0 < namedSnapshots.size() : "Something broke the conditional";
Review Comment:
this is always true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
