[ 
https://issues.apache.org/jira/browse/SOLR-16498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624923#comment-17624923
 ] 

Joshua Ouma commented on SOLR-16498:
------------------------------------

I would like to work on this. My understanding so far is for example in the 
following code from BasicHttpSolrClientTest
{code:java}
HttpSolrClient client = getHttpSolrClient(jetty.getBaseUrl().toString() + 
"/debug/foo")
{code}
Since HttpSolrClient is deprecated, it will be refactored to call 
getUrlFrom(SolrClient) static utility where the client will be cast to a known 
class . In this case the class would be HttpSolrClient.

In this issue we just need to implement the getUrlFrom(SolrClient) static 
utility method that will interrogated the passed SolrClient and respond 
accordingly

> Tests need the URL from a SolrClient; don't require legacy clients
> ------------------------------------------------------------------
>
>                 Key: SOLR-16498
>                 URL: https://issues.apache.org/jira/browse/SOLR-16498
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Tests
>            Reporter: David Smiley
>            Priority: Major
>              Labels: newdev
>
> SOLR-16368 could not switch many tests away from some legacy/deprecated 
> SolrClient classes because they were either getting the URL or Apache 
> HttpClient instance out of the client.  This issue aims to solve this so that 
> our tests don't depend on a legacy client and don't depend on Apache 
> HttpClient either.  We would prefer a non-dependency approach using [Java 
> 11's new 
> HttpClient|https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/package-summary.html].
>   And we need to figure out how to get the URL from the SolrClient in a more 
> general way.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to