[ 
https://issues.apache.org/jira/browse/SOLR-16498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625108#comment-17625108
 ] 

David Smiley commented on SOLR-16498:
-------------------------------------

Hi Joshua.

bq. we just need to implement the getUrlFrom(SolrClient) static utility method

That is the trivial part.  I think we need to update _at least_ 1 test that is 
using it to use the JDK's built-in HttpClient, as described in the issue 
description.

The only concern I have on difficulty / problems here is the SSL configuration. 
 Sometimes a test runs in SSL mode, and I'm not sure what the needs are of a 
client to connect to it.  @hossman do you know?

> Tests need the URL from a SolrClient; don't require legacy clients
> ------------------------------------------------------------------
>
>                 Key: SOLR-16498
>                 URL: https://issues.apache.org/jira/browse/SOLR-16498
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Tests
>            Reporter: David Smiley
>            Priority: Major
>              Labels: newdev
>
> SOLR-16368 could not switch many tests away from some legacy/deprecated 
> SolrClient classes because they were either getting the URL or Apache 
> HttpClient instance out of the client.  This issue aims to solve this so that 
> our tests don't depend on a legacy client and don't depend on Apache 
> HttpClient either.  We would prefer a non-dependency approach using [Java 
> 11's new 
> HttpClient|https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/package-summary.html].
>   And we need to figure out how to get the URL from the SolrClient in a more 
> general way.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to