AAnakhe commented on code in PR #1080:
URL: https://github.com/apache/solr/pull/1080#discussion_r1010192031
##########
solr/core/src/test/org/apache/solr/handler/admin/api/V2CollectionAPIMappingTest.java:
##########
@@ -87,13 +96,15 @@ public void testGetCollectionStatus() throws Exception {
@Test
- public void testRenameCollectionAllParams() throws Exception {
- final SolrParams v1Params = captureConvertedV1Params(
- "/collections/collName", "POST", "{\"rename\": {\"to\":
\"targetColl\"}}");
+ public void testRenameCollectionAllParams(){
+ final SolrQueryRequest request =
runRenameCollectionsApi("/collections/collName");
Review Comment:
> `Test result returns java.lang.AssertionError: expected:<rename> but
was:<null>`
>
> What if we mock `SolrQueryRequest` and `SolrQueryResponse` , pass them to
the`public void renameCollection(SolrQueryRequest req, SolrQueryResponse rsp)`
method of the API then perform the assertions
Please I need more clarification on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
