gerlowskija commented on code in PR #1080:
URL: https://github.com/apache/solr/pull/1080#discussion_r1017025758
##########
solr/core/src/test/org/apache/solr/handler/admin/api/V2CollectionAPIMappingTest.java:
##########
@@ -87,13 +96,15 @@ public void testGetCollectionStatus() throws Exception {
@Test
- public void testRenameCollectionAllParams() throws Exception {
- final SolrParams v1Params = captureConvertedV1Params(
- "/collections/collName", "POST", "{\"rename\": {\"to\":
\"targetColl\"}}");
+ public void testRenameCollectionAllParams(){
+ final SolrQueryRequest request =
runRenameCollectionsApi("/collections/collName");
Review Comment:
Ah, not quite. Or at least, I didn't mean to suggest that?
What I probably meant to say is that Solr is moving away from its
traditional v2 API framework to a framework based on JAX-RS.
`captureConvertedV1Params` is a nice utility for testing APIs implemented using
the "traditional" (i.e. non JAX-RS) framework.
In the long run I'd expect to see usage of `captureConvertedV1Params`
decline, but not because it's deprecated or shouldn't be used - just because
things will switch over to JAX-RS as time goes by. This PR uses the
traditional framework (which is absolutely still valid), so it's fine/normal to
use `captureConvertedV1Params` in your tests.
I'll push up a commit here to help get the unit test over the line and then
hopefully we can get this merged 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
