risdenk commented on code in PR #585:
URL: https://github.com/apache/solr/pull/585#discussion_r1013409554
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -278,6 +295,10 @@ public void close() {
assert ObjectReleaseTracker.release(this);
}
+ public void setAuthenticationStore(AuthenticationStore authenticationStore) {
+ this.authenticationStore.updateAuthenticationStore(authenticationStore);
Review Comment:
good question - not sure. looks like we don't need this change. removed in
3ad2030756edb7e4a94e3745c8b19839c7ba5f0a
##########
solr/core/src/java/org/apache/solr/request/json/RequestUtil.java:
##########
@@ -76,8 +76,13 @@ public static void processParams(
String[] jsonFromParams = map.remove(JSON);
for (ContentStream cs : req.getContentStreams()) {
+ // if BinaryResponseParser.BINARY_CONTENT_TYPE, let the following fail
below - we may have
+ // adjusted the content without updating the content type
+ // problem in this case happens in a few tests, one seems to happen
with kerberos and remote
+ // node query (HttpSolrCall's request proxy)
+
String contentType = cs.getContentType();
- if (contentType == null || !contentType.contains("/json")) {
+ if (contentType == null || (!contentType.contains("/json"))) {
Review Comment:
more is better? I have no idea - removed now :) see
13cf43059e35ae26d298891e2682142342dce833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
