risdenk commented on code in PR #585:
URL: https://github.com/apache/solr/pull/585#discussion_r1013510879
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -278,6 +295,10 @@ public void close() {
assert ObjectReleaseTracker.release(this);
}
+ public void setAuthenticationStore(AuthenticationStore authenticationStore) {
+ this.authenticationStore.updateAuthenticationStore(authenticationStore);
Review Comment:
Well.... hit this error in tests after reverting this change:
```
2> 61637 INFO
(TEST-Http2SolrClientTest.testSetCredentialsWithSysProps-seed#[6AB847A636F3DA61])
[] o.a.s.SolrTestCaseJ4 ###Ending testSetCredentialsWithSysProps
> java.lang.IllegalStateException
> at
__randomizedtesting.SeedInfo.seed([6AB847A636F3DA61:9706EAF254309277]:0)
> at
org.eclipse.jetty.client.HttpClient.setAuthenticationStore(HttpClient.java:327)
```
https://github.com/eclipse/jetty.project/blob/jetty-10.0.x/jetty-client/src/main/java/org/eclipse/jetty/client/HttpClient.java#L328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
