[GitHub] [solr] risdenk commented on pull request #1184: SOLR-16555: SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

Fri, 18 Nov 2022 11:45:51 -0800 


risdenk commented on PR #1184:
URL: https://github.com/apache/solr/pull/1184#issuecomment-1320455964

   I ran this through some benchmarks - same one as the screenshots on 
SOLR-16555 and got the following:
   
   <img width="1449" alt="Screenshot 2022-11-18 at 14 44 07" 
src="https://user-images.githubusercontent.com/3384157/202789352-1fb6af4c-28f3-44df-bc16-d506b177ca2e.png";>
   <img width="792" alt="Screenshot 2022-11-18 at 14 44 24" 
src="https://user-images.githubusercontent.com/3384157/202789355-10977730-3713-4b79-83ee-69d74703ddf2.png";>
   
   I found that 
`[FixedBitSet.ensureCapacity](https://github.com/apache/solr/pull/1184/commits/f1fe35ca91a9a219dcadc29186a963e8f665e5b5)`
 isn't even needed so can skip that too. I pushed that commit 
[f1fe35c](https://github.com/apache/solr/pull/1184/commits/f1fe35ca91a9a219dcadc29186a963e8f665e5b5)
 a few minutes ago.
   
   I'll update based on David's comments in a few minutes as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to