risdenk commented on code in PR #1184:
URL: https://github.com/apache/solr/pull/1184#discussion_r1026961673
##########
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##########
@@ -1190,38 +1187,53 @@ public ProcessedFilter getProcessedFilter(DocSet
setFilter, List<Query> queries)
}
Query posQuery = QueryUtils.getAbs(q);
- sets[end] = getPositiveDocSet(posQuery);
+ DocSet docSet = getPositiveDocSet(posQuery);
// Negative query if absolute value different from original
if (Objects.equals(q, posQuery)) {
- neg[end] = false;
- // keep track of the smallest positive set.
+ // keep track of the smallest positive set; use "answer" for this.
// This optimization is only worth it if size() is cached, which it
would
// be if we don't do any set operations.
Review Comment:
I think this comment can move down to just above line 1200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
