risdenk commented on code in PR #1185:
URL: https://github.com/apache/solr/pull/1185#discussion_r1033716691
##########
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##########
@@ -476,18 +479,22 @@ private void addFoldersToSharedLib(Set<String> libDirs) {
// Adds modules to shared classpath
private void initModules() {
+ Path solrInstallDir = getSolrInstallDir();
+ if (solrInstallDir == null) {
+ return;
Review Comment:
I don't think `getSolrInstallDir()` should return an exception if the
property isn't set. Returning `null` from that method is 100% valid since it is
saying "there is no install dir" - `initModules` and `setupSharedLib` should
handle the case of no install dir. I agree that there should be a message
returned in that case if there is no install dir.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
