janhoy commented on code in PR #1185:
URL: https://github.com/apache/solr/pull/1185#discussion_r1033841038
##########
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##########
@@ -476,18 +479,22 @@ private void addFoldersToSharedLib(Set<String> libDirs) {
// Adds modules to shared classpath
private void initModules() {
+ Path solrInstallDir = getSolrInstallDir();
+ if (solrInstallDir == null) {
+ return;
Review Comment:
This was better, although we'd probably be better off for all tests to also
set `solr.install.dir` and treat lack thereof as a configuration error. But now
we at least report why things are failing if it is not set. I'm ok with this
too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
