epugh commented on code in PR #1149:
URL: https://github.com/apache/solr/pull/1149#discussion_r1033801926
##########
solr/core/src/test/org/apache/solr/update/TestInPlaceUpdatesDistrib.java:
##########
@@ -1489,6 +1489,12 @@ private String getBaseUrl(String id) {
return slice.getLeader().getCoreUrl();
}
+ protected String getBaseUrl(HttpSolrClient client) {
+ return client
+ .getBaseURL()
+ .substring(0, client.getBaseURL().length() -
DEFAULT_COLLECTION.length() - 1);
+ }
Review Comment:
adding a comment.. and someday, when we eliminate HttpSolrClient, will
have to properly figure out how to get the underlying Jetty server...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
