epugh commented on PR #1149: URL: https://github.com/apache/solr/pull/1149#issuecomment-1329716560
> So I see `DEFAULT_COLLECTION` used in a few places and `collection1` hardcoded in others. I think I prefer `DEFAULT_COLLECTION` if possible to avoid hard coding `collection1`? so, `DEFAULT_COLLECTION` is defined twice in the code base, and as a private variable. How about we leave this as is, and if you create me a JIRA, I'll happily do anohter PR that focuses on cleaning up all the places we mix "collection1" and "DEFAULT_COLLECTION"??/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
