epugh commented on code in PR #1211:
URL: https://github.com/apache/solr/pull/1211#discussion_r1040052738
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java:
##########
@@ -88,23 +89,63 @@ public LBHttp2SolrClient(Http2SolrClient httpClient,
String... baseSolrUrls) {
this.httpClient = httpClient;
}
+ public LBHttp2SolrClient(Http2SolrClient httpClient, List<String>
baseSolrUrls, Builder builder) {
Review Comment:
Humm... I may be getting confused... (honestly, if you want to push up a
commit, I'd love to see it!). Right now on `LBHttpSolrClient` we have
`protected LBHttpSolrClient(Builder builder)` and that's it... On
`LBHttp2SolrClient` we have the deprecated `public
LBHttp2SolrClient(Http2SolrClient httpClient, String... baseSolrUrls) ` and
`private LBHttp2SolrClient(Http2SolrClient httpClient, List<String>
baseSolrUrls)` methods...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
