dsmiley commented on code in PR #1211:
URL: https://github.com/apache/solr/pull/1211#discussion_r1039858105
##########
solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java:
##########
@@ -534,16 +534,15 @@ public SortedMap<Class<? extends Filter>, String>
getExtraRequestFilters() {
}
protected SolrClient createNewSolrClient(int port) {
- try {
- // setup the client...
- String baseUrl = buildUrl(port);
- if (baseUrl.endsWith("/")) {
- return getHttpSolrClient(baseUrl + DEFAULT_TEST_CORENAME);
- } else {
- return getHttpSolrClient(baseUrl + "/" + DEFAULT_TEST_CORENAME);
- }
- } catch (Exception ex) {
- throw new RuntimeException(ex);
+ return getHttpSolrClient(getServerUrl(port));
+ }
+
+ protected String getServerUrl(int port) {
Review Comment:
For a new PR is fine; thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
