stillalex commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1051253430
##########
solr/core/src/java/org/apache/solr/core/SolrCores.java:
##########
@@ -193,9 +165,9 @@ List<SolrCore> getCores() {
* @return An unsorted list. This list is a new copy, it can be modified by
the caller (e.g. it
* can be sorted).
*/
- List<String> getLoadedCoreNames() {
+ public List<String> getLoadedCoreNames() {
synchronized (modifyLock) {
- return distinctSetsUnion(cores.keySet(),
getTransientCacheHandler().getLoadedCoreNames());
+ return new ArrayList<>(cores.keySet());
Review Comment:
would you consider returning an immutable list here? (as in List.copyOf())
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
