stillalex commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1058547533
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -423,6 +424,20 @@ public CoreContainer(NodeConfig config, CoresLocator
locator, boolean asyncSolrC
this.allowListUrlChecker = AllowListUrlChecker.create(config);
}
+ private SolrCores newSolrCores(NodeConfig config) {
Review Comment:
does this need the 'config' param? it could use the already existing
'this.cfg' (similar to the loader)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
