alessandrobenedetti commented on code in PR #1245:
URL: https://github.com/apache/solr/pull/1245#discussion_r1055641407
##########
solr/core/src/java/org/apache/solr/search/neural/KnnQParser.java:
##########
@@ -84,30 +84,20 @@ public Query parse() {
}
private Query getFilterQuery() throws SolrException {
- if (!isFilter()) {
+ boolean isSubQuery = recurseCount != 0;
+ if (!isFilter() && !isSubQuery) {
Review Comment:
For the isFilter:
I may want to run a Knn search as a filter, to then score the documents by
any lexical query, it's probably unlikely, but possible.
The check avoid you end up with an infinite recursion with
org.apache.solr.search.QueryUtils#parseFilterQueries.
But the check also avoid a KnnQuery in the filters to capture the other
filter queries and use them as pre-filters, so it's not ideal anyway.
Tagging @eliaporciani if he has any better idea.
I'll think about it
For the "isSubQuery", I want to avoid ending up with the infinite recursion
frange and similar filters may end up (the original issue in the ticket).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
