[
https://issues.apache.org/jira/browse/SOLR-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653317#comment-17653317
]
ASF subversion and git services commented on SOLR-10452:
--------------------------------------------------------
Commit 9cabc8e188a0c9beba2047c21b3ab9299365586d in solr's branch
refs/heads/branch_9x from Eric Pugh
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=9cabc8e188a ]
SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder
methods (#1253)
Moved setQueryParams to the Builder, and renamed it to setUrlParamNames, to
make it clearer that it's just the name of url parameters.
Co-authored-by: Alex Deparvu <[email protected]>
Co-authored-by: David Smiley <[email protected]>
> setQueryParams should be deprecated in favor of SolrClientBuilder methods
> -------------------------------------------------------------------------
>
> Key: SOLR-10452
> URL: https://issues.apache.org/jira/browse/SOLR-10452
> Project: Solr
> Issue Type: Sub-task
> Components: SolrJ
> Reporter: Jason Gerlowski
> Assignee: Eric Pugh
> Priority: Minor
> Fix For: 7.0, main (10.0), 9.2
>
> Attachments: SOLR-10452.patch
>
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
> Now that builders are in place for {{SolrClients}}, the setters used in each
> {{SolrClient}} can be deprecated, and their functionality moved over to the
> Builders. This change brings a few benefits:
> - unifies {{SolrClient}} configuration under the new Builders. It'll be nice
> to have all the knobs, and levers used to tweak {{SolrClient}}s available in
> a single place (the Builders).
> - reduces {{SolrClient}} thread-safety concerns. Currently, clients are
> mutable. Using some {{SolrClient}} setters can result in erratic and "trappy"
> behavior when the clients are used across multiple threads.
> This subtask endeavors to change this behavior for the {{setQueryParams}}
> setter on all {{SolrClient}} implementations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
