risdenk commented on code in PR #1239:
URL: https://github.com/apache/solr/pull/1239#discussion_r1062648382
##########
solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java:
##########
@@ -238,9 +238,14 @@ public List<String> getAllConfigFiles(String configName)
throws IOException {
@Override
public FileVisitResult visitFile(Path file, BasicFileAttributes
attrs)
throws IOException {
- // don't include hidden (.) files
- if (!Files.isHidden(file)) {
- filePaths.add(configDir.relativize(file).toString());
+ Path filePath = configDir.relativize(file);
+ String filePathStr = filePath.toString();
+ filePathStr =
+ filePathStr.replace(
+ filePath.getFileSystem().getSeparator(), "/"); //
normalize slashes
+ // don't include .metadata.json hidden file
+ if (!filePathStr.equals(METADATA_FILE)) {
+ filePaths.add(filePathStr);
Review Comment:
I'm putting together a PR to show what I mean about using Path instead of
string manipulation. I'll have it up shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
