risdenk commented on code in PR #1239:
URL: https://github.com/apache/solr/pull/1239#discussion_r1064697931
##########
solr/core/src/test/org/apache/solr/core/TestConfigSetService.java:
##########
@@ -77,24 +72,31 @@ public void testConfigSetServiceOperations() throws
IOException {
byte[] testdata = "test data".getBytes(StandardCharsets.UTF_8);
Path configDir = createTempDir("testconfig");
- Files.createFile(configDir.resolve("solrconfig.xml"));
- Files.write(configDir.resolve("file1"), testdata);
- Files.createFile(configDir.resolve("file2"));
- Files.createDirectory(configDir.resolve("subdir"));
- Files.createFile(configDir.resolve("subdir").resolve("file3"));
+ String solrConfigXml = "solrconfig.xml";
+ Files.createFile(configDir.resolve(solrConfigXml));
+ String file1 = "file1";
+ Files.write(configDir.resolve(file1), testdata);
+ String file2 = "file2";
+ Files.createFile(configDir.resolve(file2));
+ String subDirPath = "subdir";
+ String subdir = subDirPath + "/";
+ Files.createDirectory(configDir.resolve(subDirPath));
+ String file3 = subdir + "file3";
+ Files.createFile(configDir.resolve(subDirPath).resolve("file3"));
+ String file4 = subdir + "file4";
Review Comment:
Fixed in c445c08e2f31b18a8b047051a9cea5ca3f582bf1
##########
solr/core/src/test/org/apache/solr/core/TestConfigSetService.java:
##########
@@ -108,16 +110,14 @@ public void testConfigSetServiceOperations() throws
IOException {
assertTrue(configSetService.getConfigMetadata(configName).containsKey("foo"));
List<String> configFiles = configSetService.getAllConfigFiles(configName);
- assertEquals(
- configFiles.toString(),
- "[file1, file2, solrconfig.xml, subdir/, subdir/file3, subdir/file4]");
+ assertEquals(configFiles, List.of(file1, file2, solrConfigXml, subdir,
file3, file4));
Review Comment:
Fixed in c445c08e2f31b18a8b047051a9cea5ca3f582bf1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
