[
https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679855#comment-17679855
]
Ishan Chattopadhyaya commented on SOLR-15616:
---------------------------------------------
bq. you made not 1 but 2 commits that broke the build - this is basic
correctness that you didn't even run gradlew check ahead of time
When the first commit broke the precommit, the other commits were just blind
attempts to rectify the problem. Each of those subsequent commits fixed some of
the reported problems. Without making those commits, I had no way to know if
the build is back to normal or not, since "gradlew check" doesn't work for me.
bq. you didn't put a PR
I'm not required to.
bq. You didn't read the messages in the build about localSettings being
required - this wasted my time for both broken builds and pointing out the
messages that are in the build
There is no such message. I am not sure if you're even reading the same things
as I am. I regret the time you wasted.
bq. you knew your checks weren't working and decided to push anyway
Yes, it was a mistake. I was hoping for the best, clearly optimism doesn't
always pay off.
bq. you broke the build multiple times. This is never ok.
Yeah, not ok. But, that's part of development. That's why we have CI. This
isn't the first time someone broke a build, not the last time it will happen.
bq. Following your logic on other issues you should have reverted the change
immediately. Not continue to push broken commits.
Yes, I should have.
> Allow thread metrics to be cached
> ---------------------------------
>
> Key: SOLR-15616
> URL: https://issues.apache.org/jira/browse/SOLR-15616
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Reporter: Ishan Chattopadhyaya
> Assignee: Ishan Chattopadhyaya
> Priority: Major
> Fix For: 9.2
>
> Attachments: SOLR-15616-2.patch, SOLR-15616-9x.patch,
> SOLR-15616.patch, SOLR-15616.patch
>
>
> Computing JVM metrics for threads can be expensive, and we should provide
> option to users to avoid doing so on every call to the metrics API
> (group=jvm).
> solr.xml:
> {code}
> <solr>
> <metrics enabled=true>
> <caching>
> <int name="threadsIntervalSeconds">2</int>
> </caching>
> ..
> </metrics>
> </solr>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
