[
https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680002#comment-17680002
]
Noble Paul commented on SOLR-15616:
-----------------------------------
{quote} you should have reverted the change immediately.
{quote}
I think reverting is not bad at all if we can't fix things right away. It is
not a defeat if someone reverts their commits. I'm not sure if reverting is a
good option for precommit errors
> Allow thread metrics to be cached
> ---------------------------------
>
> Key: SOLR-15616
> URL: https://issues.apache.org/jira/browse/SOLR-15616
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Reporter: Ishan Chattopadhyaya
> Assignee: Ishan Chattopadhyaya
> Priority: Major
> Fix For: 9.2
>
> Attachments: SOLR-15616-2.patch, SOLR-15616-9x.patch,
> SOLR-15616.patch, SOLR-15616.patch, Screenshot from 2023-01-23 21-18-19.png
>
>
> Computing JVM metrics for threads can be expensive, and we should provide
> option to users to avoid doing so on every call to the metrics API
> (group=jvm).
> solr.xml:
> {code}
> <solr>
> <metrics enabled=true>
> <caching>
> <int name="threadsIntervalSeconds">2</int>
> </caching>
> ..
> </metrics>
> </solr>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]