dsmiley commented on PR #1313: URL: https://github.com/apache/solr/pull/1313#issuecomment-1407120367
Thanks for your help Kevin! User error on my part -- doh! Maybe if that dependency analysis could dependOn "check". I took a quick stab at this; sorta worked, sorta didn't. Then I noticed it's likely the latest version of this plugin added this. I don't see where we specify a version to use for this plugin. RE "api": Here's a practical example. The solr:hadoop-auth module depends on solr:core (obviously). Solr:core has an "api" dependency on solr:solrj-zookeeper. The idea is that we have a dependency that is significant / prominent; it's not an internal implementation detail. Its types show up in public methods/classes of solr-core in places. Thus I think it's needlessly verbose for solr:hadoop-auth's build (or any other things that depend on solr-core) to specify any of solr-core's "api" dependencies. These dependencies are on the surface, not buried below (like Guava say). Today it has to because of this build dependency analysis plugin. This plugin was ported from the Maven world where this "api" vs "implementation" distinction didn't exist. I'm dubious about how much pain/suffering is prevented from this plugin when dependencies change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
