dsmiley commented on PR #1313: URL: https://github.com/apache/solr/pull/1313#issuecomment-1407285268
> It sounds obvious to a human that we would never remove solrj-zookeeper as an api dependency from core, but the computer doesn't know that. so we need to be explicit there on the hadoop-auth module. "need"? Or else what bad thing could happen? It's only "need"ed because this plugin we elected to use, for both better and here worse, doesn't recognize "api" dependencies as being different from "implementation". IMO of course. > but we don't have to declare EVERY dependency form solr:core in hadoop-auth - only the ones that hadoop-auth is actually using in its classes. It may not be many lines but I argue these particular lines, ones for transitive "api" dependencies, have zero value. The best example I can give is solr-core depending on solrJ. Basically every module depends on solr-core, and thus thanks to this build plugin further specifies SolrJ explicitly. Is there value (relevance or consequence) in this tedious house-keeping? Any way, I suppose the plugin offers more value than annoyance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
