vinayakphegde commented on code in PR #1360:
URL: https://github.com/apache/solr/pull/1360#discussion_r1108754672
##########
solr/core/src/java/org/apache/solr/update/UpdateLog.java:
##########
@@ -1940,7 +1940,12 @@ public void doReplay(TransactionLog translog) {
ThreadLocal<UpdateRequestProcessor> procThreadLocal =
ThreadLocal.withInitial(
() -> {
- var proc = processorChain.createProcessor(req, rsp);
+ UpdateRequestProcessor proc;
+ try {
+ proc = processorChain.createProcessor(req, rsp);
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
Review Comment:
Hi @risdenk
if we see this lucene commit
https://github.com/apache/lucene/pull/11998/files , the
`KNearestNeighborDocumentClassifier` constructor now throws IOException
we are using that in `ClassificationUpdateProcessor`'s constructor
so that's why I added `throws IOExceptio`n in the
`ClassificationUpdateProcessor` constructor
and we are calling `ClassificationUpdateProcessor` from
ClassificationUpdateProcessorFactory#getInstance()
so I had to throw IOException from
ClassificationUpdateProcessorFactory#getInstance()
since it is inherited from UpdateRequestProcessorFactory, I had to add it
there as well.
and so on for other related files like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
