vinayakphegde commented on code in PR #1360:
URL: https://github.com/apache/solr/pull/1360#discussion_r1112862200
##########
solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java:
##########
@@ -359,14 +373,26 @@ public PointValues getPointValues(String field) {
}
@Override
- public VectorValues getVectorValues(String field) {
+ public FloatVectorValues getFloatVectorValues(String field) {
+ ensureOpen();
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public ByteVectorValues getByteVectorValues(String field) {
ensureOpen();
- return VectorValues.EMPTY;
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public TopDocs searchNearestVectors(
+ String field, float[] target, int k, Bits acceptDocs, int visitedLimit) {
+ return null;
}
@Override
public TopDocs searchNearestVectors(
- String field, float[] target, int k, Bits acceptDocs, int visitedLimit)
throws IOException {
+ String field, byte[] target, int k, Bits acceptDocs, int visitedLimit) {
Review Comment:
Okay, Will add back the `throws IOException` to the `float[]` variant as
well as the `byte[]` variant of `searchNearestVectors()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
