dsmiley commented on code in PR #1182:
URL: https://github.com/apache/solr/pull/1182#discussion_r1128029913
##########
solr/core/src/test/org/apache/solr/cloud/SolrCloudExampleTest.java:
##########
@@ -260,22 +259,22 @@ protected void doTestConfigUpdate(String
testCollectionName, String solrUrl) thr
"/" + testCollectionName + "/config",
new ModifiableSolrParams()));
maxTimeFromConfig =
- SolrCLI.atPath(
- "/updateHandler/autoSoftCommit/maxTime",
- (Map<String, Object>) configJson.get("config"));
+ configJson._get("/config/updateHandler/autoSoftCommit/maxTime",
Collections.emptyMap());
assertNotNull(maxTimeFromConfig);
assertEquals(maxTime, maxTimeFromConfig);
if (log.isInfoEnabled()) {
log.info("live_nodes_count : {}",
cloudClient.getClusterState().getLiveNodes());
}
+ // Need to use the _get(List, Object) here because of /query in the path
assertEquals(
"Should have been able to get a value from the /query request
handler",
"explicit",
- SolrCLI.atPath(
- "/requestHandler/\\/query/defaults/echoParams",
- (Map<String, Object>) configJson.get("config")));
+ configJson._get(
+ new ArrayList<>(
+ Arrays.asList("config", "requestHandler", "/query",
"defaults", "echoParams")),
Review Comment:
why new ArrayList ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
