dsmiley commented on code in PR #1182:
URL: https://github.com/apache/solr/pull/1182#discussion_r1142492764
##########
solr/core/src/java/org/apache/solr/filestore/DistribPackageStore.java:
##########
@@ -181,14 +189,17 @@ private boolean fetchFileFromNodeAndPersist(String
fromNode) {
ByteBuffer metadata = null;
Map<?, ?> m = null;
- try {
- metadata =
- Utils.executeGET(
- coreContainer.getUpdateShardHandler().getDefaultHttpClient(),
- baseUrl + "/node/files" + getMetaPath(),
- Utils.newBytesConsumer((int) MAX_PKG_SIZE));
+ try (SolrClient solrClient = new
Http2SolrClient.Builder(baseUrl).build()) {
+ GenericSolrRequest request =
+ new GenericSolrRequest(
+ SolrRequest.METHOD.GET,
+ "/node/files" + getMetaPath(),
+ new ModifiableSolrParams().add(CommonParams.WT,
CommonParams.JSON));
Review Comment:
Looks like you were hunting for string constants wherever you could find
them. In this line of code, we want "json" as a value, not as a parameter name
(which it is also, actually). You can just use "json" string literal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
