[
https://issues.apache.org/jira/browse/SOLR-16507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17699158#comment-17699158
]
David Smiley commented on SOLR-16507:
-------------------------------------
SolrCloudManager has a {{request}} method that you can use. Yeah it's kind of
weird to see this instead of a SolrClient that we are all familiar with but
whatever.
The V2 API situation is very much in flux... maybe look at GenericSolrRequest
instead? CC [~gerlowskija]
Instead of the multiple checks for each part of the path, try
NamedList.findRecursive which will help some. I don't know why you implicitly
cast a Number.doubleValue to a Double Object... it should be a double
primitive. One less check.
> Remove NodeStateProvider & Snitch
> ---------------------------------
>
> Key: SOLR-16507
> URL: https://issues.apache.org/jira/browse/SOLR-16507
> Project: Solr
> Issue Type: Task
> Reporter: David Smiley
> Priority: Major
> Labels: newdev
>
> The NodeStateProvider is a relic relating to the old autoscaling framework
> that was removed in Solr 9. The only remaining usage of it is for
> SplitShardCmd to check the disk space. For this, it could use the metrics
> api.
> I think we'll observe that Snitch and other classes in
> org.apache.solr.common.cloud.rule can be removed as well, as it's related to
> NodeStateProvider.
> Only
> org.apache.solr.cluster.placement.impl.AttributeFetcherImpl#getMetricSnitchTag
> and org.apache.solr.cluster.placement.impl.NodeMetricImpl refer to some
> constants in the code to be removed. Those constants could move out,
> consolidated somewhere we think is appropriate.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
