[
https://issues.apache.org/jira/browse/SOLR-16507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17699240#comment-17699240
]
Vinayak Hegde commented on SOLR-16507:
--------------------------------------
we are using SolrClientNodeStateProvider#getNodeValues here also
[https://github.com/apache/solr/blob/a6c5fa676226f52f614422f655bfe48c72e5d71f/solr/core/src/java/org/apache/solr/cluster/placement/impl/AttributeFetcherImpl.java#L148,|https://github.com/apache/solr/blob/a6c5fa676226f52f614422f655bfe48c72e5d71f/solr/core/src/java/org/apache/solr/cluster/placement/impl/AttributeFetcherImpl.java#L148]
right?
what should we do in this case?
> Remove NodeStateProvider & Snitch
> ---------------------------------
>
> Key: SOLR-16507
> URL: https://issues.apache.org/jira/browse/SOLR-16507
> Project: Solr
> Issue Type: Task
> Reporter: David Smiley
> Priority: Major
> Labels: newdev
>
> The NodeStateProvider is a relic relating to the old autoscaling framework
> that was removed in Solr 9. The only remaining usage of it is for
> SplitShardCmd to check the disk space. For this, it could use the metrics
> api.
> I think we'll observe that Snitch and other classes in
> org.apache.solr.common.cloud.rule can be removed as well, as it's related to
> NodeStateProvider.
> Only
> org.apache.solr.cluster.placement.impl.AttributeFetcherImpl#getMetricSnitchTag
> and org.apache.solr.cluster.placement.impl.NodeMetricImpl refer to some
> constants in the code to be removed. Those constants could move out,
> consolidated somewhere we think is appropriate.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
