mkhludnev commented on code in PR #1448:
URL: https://github.com/apache/solr/pull/1448#discussion_r1133592521
##########
solr/core/src/java/org/apache/solr/handler/loader/XMLLoader.java:
##########
@@ -332,6 +333,11 @@ public SolrInputDocument readDoc(XMLStreamReader parser)
throws XMLStreamExcepti
} else {
log.debug(message);
}
+ } else if (NAME.equals(attrName)) {
Review Comment:
It also allows to specify this attribute for `<doc` it other context, but
ignore it then. I can't say it's a blocker; it slightly changes behavior, and
may create wrong expectation for users.. In doubts.. .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
