vinayakphegde commented on code in PR #1448:
URL: https://github.com/apache/solr/pull/1448#discussion_r1133644334
##########
solr/core/src/java/org/apache/solr/handler/loader/XMLLoader.java:
##########
@@ -332,6 +333,11 @@ public SolrInputDocument readDoc(XMLStreamReader parser)
throws XMLStreamExcepti
} else {
log.debug(message);
}
+ } else if (NAME.equals(attrName)) {
Review Comment:
Yeah, you are right
we can pass an extra argument called `isSingleLabeledChildDoc` to the
readDoc function
if isSingleLabeledChildDoc is false and still we have the `name` attribute,
then we can log the warning like we are doing now.
what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
