vinayakphegde commented on code in PR #1448:
URL: https://github.com/apache/solr/pull/1448#discussion_r1135262913
##########
solr/core/src/java/org/apache/solr/handler/loader/XMLLoader.java:
##########
@@ -333,12 +339,14 @@ public SolrInputDocument readDoc(XMLStreamReader parser)
throws XMLStreamExcepti
log.debug(message);
}
} else {
- log.warn("XML element <doc> has invalid XML attr: {}", attrName);
+ if (!(NAME.equals(attrName) && forgiveNameAttr)) {
+ log.warn("XML element <doc> has invalid XML attr: {}", attrName);
+ }
}
}
StringBuilder text = new StringBuilder();
- String name = null;
+ String currentFieldName = null;
Review Comment:
Sure :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
