risdenk commented on code in PR #1466:
URL: https://github.com/apache/solr/pull/1466#discussion_r1144014874
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -2192,6 +2191,9 @@ public SolrCore getCore(String name) {
* @see SolrCore#close()
*/
public SolrCore getCore(String name, UUID id) {
+ if (name == null) {
+ return null;
+ }
Review Comment:
Line 2211 - getCoreInitFailures can't have null keys and so looking up name
is null caused issue. This just shortcircuits since null key would never match
anyway. The Map.of is more strict than the existing ImmutableMap around null
keys. This fixed the issue and returns the same null we would have gotten
anyway (desc is null on line 2207 and then line 2221 returns null)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
