dsmiley commented on code in PR #1466:
URL: https://github.com/apache/solr/pull/1466#discussion_r1144811614
##########
solr/core/src/java/org/apache/solr/cloud/SizeLimitedDistributedMap.java:
##########
@@ -77,7 +77,7 @@ protected boolean lessThan(Long a, Long b) {
}
};
- Map<String, Long> childToModificationZxid =
Maps.newHashMapWithExpectedSize(children.size());
+ Map<String, Long> childToModificationZxid = new
HashMap<>(children.size());
Review Comment:
The conversation/review here discusses this yesterday between Kevin and I.
I'd like to propose that we have a separate dedicated work item that has the
goal of *nobody* calling the integer single-arg constructor to HashMap or
HashSet, as it's a trap/gotcha (with probably minor down-side, granted). We
can add a utility method for creating pre-sized maps or sets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
