risdenk commented on code in PR #1466:
URL: https://github.com/apache/solr/pull/1466#discussion_r1144830743
##########
solr/core/src/java/org/apache/solr/cloud/SizeLimitedDistributedMap.java:
##########
@@ -77,7 +77,7 @@ protected boolean lessThan(Long a, Long b) {
}
};
- Map<String, Long> childToModificationZxid =
Maps.newHashMapWithExpectedSize(children.size());
+ Map<String, Long> childToModificationZxid = new
HashMap<>(children.size());
Review Comment:
I like David's idea as well. In the meantime -
30e502199996d815c2acdade8f0f3be58afc0618 adds CollectionUtil to at least handle
these two cases. We can follow up and fix the other places too. I think thats a
reasonable middle ground.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
